prevent SEGFAULT on EOF (^D) #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we submitted same fix (mine is #16) we can be PR buddies 🤗 |
|
Ha! I wonder how the heck I managed to miss yours! |
|
😆 I didn't really look at the PRs before pushing. compiling from source on macos w/ xcode means the segfault produces traceback without effort, and it's an easy fix... it's surprising there aren't 10 PRs for the same thing. that said, I've run into a bunch of segfaults which are less clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user attempts to terminate the repl with ^d (causing EOF on
stdin) thesapfapp crashes with a segmentation fault. This patch resolves that.